Add LMFDB concepts#8
Merged
Merged
Conversation
-added requirement for lmfdb-dblite
Stanoja
reviewed
May 6, 2026
Collaborator
Stanoja
left a comment
Stanoja
left a comment
There was a problem hiding this comment.
I tested and pushed 2 fixes:
- Reformatting
- Dependency for the lmf import
Everything else looks good
| self.source = Item.Source.LMFDB | ||
|
|
||
| def fetch_rows(self): | ||
| from lmf import db |
Collaborator
There was a problem hiding this comment.
I added an import for this, seems that the correct library is imported: https://github.com/roed314/lmfdb-lite
| scispacy~=0.6.2 | ||
| python-decouple~=3.8 | ||
| unidecode~=1.4.0 | ||
| lmfdb-lite[pgbinary] @ git+https://github.com/roed314/lmfdb-lite.git |
Stanoja
approved these changes
May 6, 2026
Owner
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the L-functions and Modular Forms Database (LMFDB) as a new source.
slurper.source_lmfdb.LmfdbSlurperreadskwl_knowlsrows from theLMFDB Postgres connection (via the
lmfpackage) and saves each knowl asan
Itemunder the newLMFDBsource, withhttps://www.lmfdb.org/knowledge/show/<id>as the URL.
import_lmfdbandclear_lmfdb.SlurperRunmodel + migration that records the last successful runper source. The LMFDB slurper is throttled to once every 7 days by default;
both
import_lmfdbandclear_lmfdbaccept--forceto override.rebuild_dbnow invokes the LMFDB clear/import steps with messagesexplaining the throttle.
Item.identifier,name, andurlraised from 200 → 300 chars (someWikipedia entries were getting truncated); migration
0021included.